test(core): clarify output of test_unicode #11572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- group output by functional area #10183
srl295
requested review from
ermshiperete
and removed request for
mcdurdin and
rc-swag
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
mcdurdin
reviewed
May 28, 2024
Comment on lines
90
to
96
| std::string result = block_line.substr(prefix.length()); | ||
| const std::string txt_suffix = ".txt"; // trim off this suffix | ||
| auto txt_pos = result.find(txt_suffix, 0); | ||
| if (txt_pos != std::string::npos) { | ||
| result.resize(txt_pos); | ||
| } | ||
| return result; |
There was a problem hiding this comment.
I don't understand this change?
There was a problem hiding this comment.
Maybe needs a comment! It drops the ".txt" suffix that is present in the original file.
There was a problem hiding this comment.
Previous output without this change:
block_unicode_ver 15.1.0.txt
There was a problem hiding this comment.
Gotcha, a comment would be nice to clarify why this is being done.
mcdurdin
approved these changes
May 29, 2024
Comment on lines
90
to
96
| std::string result = block_line.substr(prefix.length()); | ||
| const std::string txt_suffix = ".txt"; // trim off this suffix | ||
| auto txt_pos = result.find(txt_suffix, 0); | ||
| if (txt_pos != std::string::npos) { | ||
| result.resize(txt_pos); | ||
| } | ||
| return result; |
There was a problem hiding this comment.
Gotcha, a comment would be nice to clarify why this is being done.
|
Changes in this pull request will be available for download in Keyman version 18.0.48-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10183
Sample output:
@keymanapp-test-bot skip